The snapshot chunk size must not exceed 512K or else bvec_alloc_bs() will fail with 4K pages, and snapshot metadata needs to be usable regardless of page size. Signed-Off-By: Alasdair G Kergon Index: linux-2.6.14-rc2/drivers/md/dm-snap.c =================================================================== --- linux-2.6.14-rc2.orig/drivers/md/dm-snap.c 2005-09-26 23:01:39.000000000 +0100 +++ linux-2.6.14-rc2/drivers/md/dm-snap.c 2005-09-27 22:49:08.000000000 +0100 @@ -460,6 +460,13 @@ goto bad3; } + /* Max chunk size determined by BIO_MAX_PAGES and smallest PAGE_SIZE */ + if (chunk_size > 1024) { + ti->error = "Chunk size may not exceed 512K"; + r = -EINVAL; + goto bad3; + } + s->chunk_size = chunk_size; s->chunk_mask = chunk_size - 1; s->type = persistent;