From: Nate Diller If the requested I/O scheduler is already in place, elevator_switch simply leaves the queue alone, and returns. However, it forgets to call elevator_put, so 'echo [current_sched] > /sys/block/[dev]/queue/scheduler' will leak a reference, causing the current_sched module to be permanently pinned in memory. Signed-off-by: Nate Diller Acked-by: Jens Axboe Signed-off-by: Andrew Morton --- drivers/block/elevator.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletion(-) diff -puN drivers/block/elevator.c~block-cleanups-fix-iosched-module-refcount-leak drivers/block/elevator.c --- devel/drivers/block/elevator.c~block-cleanups-fix-iosched-module-refcount-leak 2005-09-27 23:51:35.000000000 -0700 +++ devel-akpm/drivers/block/elevator.c 2005-09-27 23:51:35.000000000 -0700 @@ -693,8 +693,10 @@ ssize_t elv_iosched_store(request_queue_ return -EINVAL; } - if (!strcmp(elevator_name, q->elevator->elevator_type->elevator_name)) + if (!strcmp(elevator_name, q->elevator->elevator_type->elevator_name)) { + elevator_put(e); return count; + } elevator_switch(q, e); return count; _