From: "Jayachandran C." This patch fixes a issue reported by Coverityin net/ipv4/ip_output.c. Error reported: After this line (or expression), the value of "skb_prev" cannot be 0 Patch description: skb_prev is assigned from skb, which cannot be NULL. This patch removes the unnecessary NULL check. Signed-off-by: Jayachandran C. Acked-by: James Morris Signed-off-by: Andrew Morton --- net/ipv4/ip_output.c | 5 +---- 1 files changed, 1 insertion(+), 4 deletions(-) diff -puN net/ipv4/ip_output.c~ipv4-remove-dead-code-from-ip_outputc net/ipv4/ip_output.c --- devel/net/ipv4/ip_output.c~ipv4-remove-dead-code-from-ip_outputc 2005-10-18 20:32:39.000000000 -0700 +++ devel-akpm/net/ipv4/ip_output.c 2005-10-18 20:32:39.000000000 -0700 @@ -1020,10 +1020,7 @@ ssize_t ip_append_page(struct sock *sk, int alloclen; skb_prev = skb; - if (skb_prev) - fraggap = skb_prev->len - maxfraglen; - else - fraggap = 0; + fraggap = skb_prev->len - maxfraglen; alloclen = fragheaderlen + hh_len + fraggap + 15; skb = sock_wmalloc(sk, alloclen, 1, sk->sk_allocation); _