From: Andrew Morton Hugh changed the contents of mmu_gather and sparc64 blew up: arch/sparc64/mm/tlb.c:22: warning: missing braces around initializer arch/sparc64/mm/tlb.c:22: warning: (near initialization for `per_cpu__mmu_gathers.vaddrs') arch/sparc64/mm/tlb.c:22: warning: braces around scalar initializer arch/sparc64/mm/tlb.c:22: warning: (near initialization for `per_cpu__mmu_gathers.vaddrs[1]') arch/sparc64/mm/tlb.c:22: warning: braces around scalar initializer arch/sparc64/mm/tlb.c:22: warning: (near initialization for `per_cpu__mmu_gathers.vaddrs[2]') arch/sparc64/mm/tlb.c:22: warning: initialization makes integer from pointer without a cast make[1]: *** [arch/sparc64/mm/tlb.o] Error 1 I think just letting the compiler zero everything out is future-safe? Cc: Hugh Dickins Cc: "David S. Miller" Signed-off-by: Andrew Morton --- arch/sparc64/mm/tlb.c | 3 +-- 1 files changed, 1 insertion(+), 2 deletions(-) diff -puN arch/sparc64/mm/tlb.c~mm-tlb_finish_mmu-forget-rss-fix arch/sparc64/mm/tlb.c --- 25-sparc64/arch/sparc64/mm/tlb.c~mm-tlb_finish_mmu-forget-rss-fix 2005-10-16 00:46:18.000000000 -0700 +++ 25-sparc64-akpm/arch/sparc64/mm/tlb.c 2005-10-16 00:46:59.000000000 -0700 @@ -18,8 +18,7 @@ /* Heavily inspired by the ppc64 code. */ -DEFINE_PER_CPU(struct mmu_gather, mmu_gathers) = - { NULL, 0, 0, 0, 0, 0, { 0 }, { NULL }, }; +DEFINE_PER_CPU(struct mmu_gather, mmu_gathers) = { 0, }; void flush_tlb_pending(void) { _