From: Adrian Bunk While fixing a compile error with CONFIG_PROC_FS=n in the EDAC code, I discovered that the proc_ent member of struct mem_ctl_info is only used in a debug printk. Signed-off-by: Adrian Bunk Acked-by: Alan Cox Signed-off-by: Andrew Morton --- drivers/edac/edac_mc.c | 8 ++------ drivers/edac/edac_mc.h | 3 --- 2 files changed, 2 insertions(+), 9 deletions(-) diff -puN drivers/edac/edac_mc.c~edac-core-edac-support-code-remove-proc_ent drivers/edac/edac_mc.c --- devel/drivers/edac/edac_mc.c~edac-core-edac-support-code-remove-proc_ent 2005-11-04 19:07:17.000000000 -0800 +++ devel-akpm/drivers/edac/edac_mc.c 2005-11-04 19:07:17.000000000 -0800 @@ -461,8 +461,6 @@ void edac_mc_dump_mci(struct mem_ctl_inf printk(KERN_INFO "\tpdev = %p\n", mci->pdev); printk(KERN_INFO "\tmod_name:ctl_name = %s:%s\n", mci->mod_name, mci->ctl_name); - printk(KERN_INFO "\tproc_name = %s, proc_ent = %p\n", - mci->proc_name, mci->proc_ent); printk(KERN_INFO "\tpvt_info = %p\n\n", mci->pvt_info); } @@ -674,10 +672,8 @@ int edac_mc_add_mc(struct mem_ctl_info * goto finish; } - mci->proc_ent = create_proc_read_entry(mci->proc_name, 0, proc_mc, - mc_read_proc, (void *) mci); - - if (mci->proc_ent == NULL) { + if(create_proc_read_entry(mci->proc_name, 0, proc_mc, + mc_read_proc, (void *) mci) == NULL) { printk(KERN_WARNING "MC%d: failed to create proc entry for controller\n", mci->mc_idx); diff -puN drivers/edac/edac_mc.h~edac-core-edac-support-code-remove-proc_ent drivers/edac/edac_mc.h --- devel/drivers/edac/edac_mc.h~edac-core-edac-support-code-remove-proc_ent 2005-11-04 19:07:17.000000000 -0800 +++ devel-akpm/drivers/edac/edac_mc.h 2005-11-04 19:07:17.000000000 -0800 @@ -313,9 +313,6 @@ struct mem_ctl_info { const char *mod_ver; const char *ctl_name; char proc_name[MC_PROC_NAME_MAX_LEN + 1]; -#ifdef CONFIG_PROC_FS - struct proc_dir_entry *proc_ent; -#endif void *pvt_info; u32 ue_noinfo_count; /* Uncorrectable Errors w/o info */ u32 ce_noinfo_count; /* Correctable Errors w/o info */ _