From: Andrew Morton I keep on getting "printk: N messages suppressed" messages. We need to test netif_msg_intr() _before_ running printk_ratelimit(), because the latter updates state. Cc: Francois Romieu Cc: Jeff Garzik Signed-off-by: Andrew Morton --- drivers/net/r8169.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/net/r8169.c~r8169-printk_ratelimit-fix drivers/net/r8169.c --- devel/drivers/net/r8169.c~r8169-printk_ratelimit-fix 2005-11-12 15:35:07.000000000 -0800 +++ devel-akpm/drivers/net/r8169.c 2005-11-12 15:35:28.000000000 -0800 @@ -2516,7 +2516,7 @@ rtl8169_interrupt(int irq, void *dev_ins } while (boguscnt > 0); if (boguscnt <= 0) { - if (net_ratelimit() && netif_msg_intr(tp)) { + if (netif_msg_intr(tp) && net_ratelimit() ) { printk(KERN_WARNING "%s: Too much work at interrupt!\n", dev->name); } _