From: Mika Kukkonen Variable dcc_timeout is unsigned, so change the module_param() to reflect that, and also remove the now unneeded check in init(). Signed-of-by: Mika Kukkonen Cc: Harald Welte Signed-off-by: Andrew Morton --- net/ipv4/netfilter/ip_conntrack_irc.c | 6 +----- 1 files changed, 1 insertion(+), 5 deletions(-) diff -puN net/ipv4/netfilter/ip_conntrack_irc.c~netfilter-fix-handling-of-module-param-dcc_timeout-in-ip_conntrack_ircc net/ipv4/netfilter/ip_conntrack_irc.c --- devel/net/ipv4/netfilter/ip_conntrack_irc.c~netfilter-fix-handling-of-module-param-dcc_timeout-in-ip_conntrack_ircc 2006-01-03 22:02:53.000000000 -0800 +++ devel-akpm/net/ipv4/netfilter/ip_conntrack_irc.c 2006-01-03 22:02:53.000000000 -0800 @@ -56,7 +56,7 @@ module_param_array(ports, ushort, &ports MODULE_PARM_DESC(ports, "port numbers of IRC servers"); module_param(max_dcc_channels, int, 0400); MODULE_PARM_DESC(max_dcc_channels, "max number of expected DCC channels per IRC session"); -module_param(dcc_timeout, int, 0400); +module_param(dcc_timeout, uint, 0400); MODULE_PARM_DESC(dcc_timeout, "timeout on for unestablished DCC channels"); static const char *dccprotos[] = { "SEND ", "CHAT ", "MOVE ", "TSEND ", "SCHAT " }; @@ -254,10 +254,6 @@ static int __init init(void) printk("ip_conntrack_irc: max_dcc_channels must be a positive integer\n"); return -EBUSY; } - if (dcc_timeout < 0) { - printk("ip_conntrack_irc: dcc_timeout must be a positive integer\n"); - return -EBUSY; - } irc_buffer = kmalloc(65536, GFP_KERNEL); if (!irc_buffer) _