From: Adrian Bunk This patch contains the following cleanups: - make needlessly global functions static - every file should #include the headers containing the prototypes for it's global functions Signed-off-by: Adrian Bunk Cc: James Bottomley Signed-off-by: Andrew Morton --- drivers/scsi/scsi_sysctl.c | 1 + drivers/scsi/scsi_sysfs.c | 3 ++- drivers/scsi/scsi_transport_fc.c | 2 +- drivers/scsi/sr.c | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) diff -puN drivers/scsi/scsi_sysctl.c~drivers-scsi-small-cleanups drivers/scsi/scsi_sysctl.c --- devel/drivers/scsi/scsi_sysctl.c~drivers-scsi-small-cleanups 2006-01-05 22:48:58.000000000 -0800 +++ devel-akpm/drivers/scsi/scsi_sysctl.c 2006-01-05 22:48:58.000000000 -0800 @@ -9,6 +9,7 @@ #include #include "scsi_logging.h" +#include "scsi_priv.h" static ctl_table scsi_table[] = { diff -puN drivers/scsi/scsi_sysfs.c~drivers-scsi-small-cleanups drivers/scsi/scsi_sysfs.c --- devel/drivers/scsi/scsi_sysfs.c~drivers-scsi-small-cleanups 2006-01-05 22:48:58.000000000 -0800 +++ devel-akpm/drivers/scsi/scsi_sysfs.c 2006-01-05 22:48:58.000000000 -0800 @@ -17,6 +17,7 @@ #include #include #include +#include #include "scsi_priv.h" #include "scsi_logging.h" @@ -720,7 +721,7 @@ void scsi_remove_device(struct scsi_devi } EXPORT_SYMBOL(scsi_remove_device); -void __scsi_remove_target(struct scsi_target *starget) +static void __scsi_remove_target(struct scsi_target *starget) { struct Scsi_Host *shost = dev_to_shost(starget->dev.parent); unsigned long flags; diff -puN drivers/scsi/scsi_transport_fc.c~drivers-scsi-small-cleanups drivers/scsi/scsi_transport_fc.c --- devel/drivers/scsi/scsi_transport_fc.c~drivers-scsi-small-cleanups 2006-01-05 22:48:58.000000000 -0800 +++ devel-akpm/drivers/scsi/scsi_transport_fc.c 2006-01-05 22:48:58.000000000 -0800 @@ -1281,7 +1281,7 @@ fc_rport_tgt_remove(struct fc_rport *rpo * Notes: * This routine assumes no locks are held on entry. **/ -struct fc_rport * +static struct fc_rport * fc_rport_create(struct Scsi_Host *shost, int channel, struct fc_rport_identifiers *ids) { diff -puN drivers/scsi/sr.c~drivers-scsi-small-cleanups drivers/scsi/sr.c --- devel/drivers/scsi/sr.c~drivers-scsi-small-cleanups 2006-01-05 22:48:58.000000000 -0800 +++ devel-akpm/drivers/scsi/sr.c 2006-01-05 22:48:58.000000000 -0800 @@ -170,7 +170,7 @@ static inline void scsi_cd_put(struct sc * an inode for that to work, and we do not always have one. */ -int sr_media_change(struct cdrom_device_info *cdi, int slot) +static int sr_media_change(struct cdrom_device_info *cdi, int slot) { struct scsi_cd *cd = cdi->handle; int retval; _