From: Andrew Morton net/core/net-sysfs.c: In function `netdev_unregister_sysfs': net/core/net-sysfs.c:413: warning: suggest parentheses around && within || net/core/net-sysfs.c: In function `netdev_register_sysfs': net/core/net-sysfs.c:439: warning: suggest parentheses around && within || Cc: : Andrey Borzenkov Cc: "David S. Miller" Cc: Jeff Garzik Cc: Signed-off-by: Andrew Morton --- net/core/net-sysfs.c | 15 ++++++++------- 1 files changed, 8 insertions(+), 7 deletions(-) diff -puN net/core/net-sysfs.c~fix-sys-class-net-if-wireless-without-dev-get_wireless_stats-fix net/core/net-sysfs.c --- devel/net/core/net-sysfs.c~fix-sys-class-net-if-wireless-without-dev-get_wireless_stats-fix 2006-01-07 01:57:38.000000000 -0800 +++ devel-akpm/net/core/net-sysfs.c 2006-01-07 01:57:38.000000000 -0800 @@ -409,8 +409,8 @@ void netdev_unregister_sysfs(struct net_ sysfs_remove_group(&class_dev->kobj, &netstat_group); #ifdef WIRELESS_EXT - if ((net->get_wireless_stats || - net->wireless_handlers && net->wireless_handlers->get_wireless_stats)) + if (net->get_wireless_stats || (net->wireless_handlers && + net->wireless_handlers->get_wireless_stats)) sysfs_remove_group(&class_dev->kobj, &wireless_group); #endif class_device_del(class_dev); @@ -435,11 +435,12 @@ int netdev_register_sysfs(struct net_dev goto out_unreg; #ifdef WIRELESS_EXT - if ((net->get_wireless_stats || - net->wireless_handlers && net->wireless_handlers->get_wireless_stats) && - (ret = sysfs_create_group(&class_dev->kobj, &wireless_group))) - goto out_cleanup; - + if (net->get_wireless_stats || (net->wireless_handlers && + net->wireless_handlers->get_wireless_stats)) { + ret = sysfs_create_group(&class_dev->kobj, &wireless_group); + if (ret) + goto out_cleanup; + } return 0; out_cleanup: if (net->get_stats) _