From: Martin Schwidefsky Remove useless spin_retry_counter and fix compilation for UP kernels. Signed-off-by: Martin Schwidefsky Signed-off-by: Andrew Morton --- arch/s390/lib/Makefile | 3 ++- arch/s390/lib/spinlock.c | 7 ------- kernel/sysctl.c | 2 +- 3 files changed, 3 insertions(+), 9 deletions(-) diff -puN arch/s390/lib/Makefile~s390-spinlock-fixes arch/s390/lib/Makefile --- 25/arch/s390/lib/Makefile~s390-spinlock-fixes Thu Jan 12 17:02:35 2006 +++ 25-akpm/arch/s390/lib/Makefile Thu Jan 12 17:02:35 2006 @@ -4,5 +4,6 @@ EXTRA_AFLAGS := -traditional -lib-y += delay.o string.o spinlock.o +lib-y += delay.o string.o lib-y += $(if $(CONFIG_64BIT),uaccess64.o,uaccess.o) +lib-$(CONFIG_SMP) += spinlock.o \ No newline at end of file diff -puN arch/s390/lib/spinlock.c~s390-spinlock-fixes arch/s390/lib/spinlock.c --- 25/arch/s390/lib/spinlock.c~s390-spinlock-fixes Thu Jan 12 17:02:35 2006 +++ 25-akpm/arch/s390/lib/spinlock.c Thu Jan 12 17:02:35 2006 @@ -13,7 +13,6 @@ #include #include -atomic_t spin_retry_counter; int spin_retry = 1000; /** @@ -45,7 +44,6 @@ _raw_spin_lock_wait(raw_spinlock_t *lp, _diag44(); count = spin_retry; } - atomic_inc(&spin_retry_counter); if (_raw_compare_and_swap(&lp->lock, 0, pc) == 0) return; } @@ -58,7 +56,6 @@ _raw_spin_trylock_retry(raw_spinlock_t * int count = spin_retry; while (count-- > 0) { - atomic_inc(&spin_retry_counter); if (_raw_compare_and_swap(&lp->lock, 0, pc) == 0) return 1; } @@ -77,7 +74,6 @@ _raw_read_lock_wait(raw_rwlock_t *rw) _diag44(); count = spin_retry; } - atomic_inc(&spin_retry_counter); old = rw->lock & 0x7fffffffU; if (_raw_compare_and_swap(&rw->lock, old, old + 1) == old) return; @@ -92,7 +88,6 @@ _raw_read_trylock_retry(raw_rwlock_t *rw int count = spin_retry; while (count-- > 0) { - atomic_inc(&spin_retry_counter); old = rw->lock & 0x7fffffffU; if (_raw_compare_and_swap(&rw->lock, old, old + 1) == old) return 1; @@ -111,7 +106,6 @@ _raw_write_lock_wait(raw_rwlock_t *rw) _diag44(); count = spin_retry; } - atomic_inc(&spin_retry_counter); if (_raw_compare_and_swap(&rw->lock, 0, 0x80000000) == 0) return; } @@ -124,7 +118,6 @@ _raw_write_trylock_retry(raw_rwlock_t *r int count = spin_retry; while (count-- > 0) { - atomic_inc(&spin_retry_counter); if (_raw_compare_and_swap(&rw->lock, 0, 0x80000000) == 0) return 1; } diff -puN kernel/sysctl.c~s390-spinlock-fixes kernel/sysctl.c --- 25/kernel/sysctl.c~s390-spinlock-fixes Thu Jan 12 17:02:35 2006 +++ 25-akpm/kernel/sysctl.c Thu Jan 12 17:02:35 2006 @@ -656,7 +656,7 @@ static ctl_table kern_table[] = { .mode = 0644, .proc_handler = &proc_dointvec, }, -#if defined(CONFIG_S390) +#if defined(CONFIG_S390) && defined(CONFIG_SMP) { .ctl_name = KERN_SPIN_RETRY, .procname = "spin_retry", _