From: Adrian Bunk This patch contains the following possible cleanups: - make needlessly global code static - #if 0 the following unused global functions: - qla_sup.c: qla24xx_get_flash_manufacturer - qla_sup.c: qla24xx_write_flash_data Signed-off-by: Adrian Bunk Cc: Andrew Vasquez Cc: James Bottomley Signed-off-by: Andrew Morton --- drivers/scsi/qla2xxx/qla_os.c | 12 ++++++------ drivers/scsi/qla2xxx/qla_sup.c | 8 ++++++-- 2 files changed, 12 insertions(+), 8 deletions(-) diff -puN drivers/scsi/qla2xxx/qla_os.c~drivers-scsi-qla2xxx-possible-cleanups drivers/scsi/qla2xxx/qla_os.c --- 25/drivers/scsi/qla2xxx/qla_os.c~drivers-scsi-qla2xxx-possible-cleanups Fri Jan 13 17:55:05 2006 +++ 25-akpm/drivers/scsi/qla2xxx/qla_os.c Fri Jan 13 17:55:05 2006 @@ -268,7 +268,7 @@ qla24xx_pci_info_str(struct scsi_qla_hos return str; } -char * +static char * qla2x00_fw_version_str(struct scsi_qla_host *ha, char *str) { char un_str[10]; @@ -306,7 +306,7 @@ qla2x00_fw_version_str(struct scsi_qla_h return (str); } -char * +static char * qla24xx_fw_version_str(struct scsi_qla_host *ha, char *str) { sprintf(str, "%d.%02d.%02d ", ha->fw_major_version, @@ -582,7 +582,7 @@ qla2x00_wait_for_loop_ready(scsi_qla_hos * * Note: **************************************************************************/ -int +static int qla2xxx_eh_abort(struct scsi_cmnd *cmd) { scsi_qla_host_t *ha = to_qla_host(cmd->device->host); @@ -716,7 +716,7 @@ qla2x00_eh_wait_for_pending_target_comma * SUCCESS/FAILURE (defined as macro in scsi.h). * **************************************************************************/ -int +static int qla2xxx_eh_device_reset(struct scsi_cmnd *cmd) { scsi_qla_host_t *ha = to_qla_host(cmd->device->host); @@ -847,7 +847,7 @@ qla2x00_eh_wait_for_pending_commands(scs * SUCCESS/FAILURE (defined as macro in scsi.h). * **************************************************************************/ -int +static int qla2xxx_eh_bus_reset(struct scsi_cmnd *cmd) { scsi_qla_host_t *ha = to_qla_host(cmd->device->host); @@ -908,7 +908,7 @@ eh_bus_reset_done: * * Note: **************************************************************************/ -int +static int qla2xxx_eh_host_reset(struct scsi_cmnd *cmd) { scsi_qla_host_t *ha = to_qla_host(cmd->device->host); diff -puN drivers/scsi/qla2xxx/qla_sup.c~drivers-scsi-qla2xxx-possible-cleanups drivers/scsi/qla2xxx/qla_sup.c --- 25/drivers/scsi/qla2xxx/qla_sup.c~drivers-scsi-qla2xxx-possible-cleanups Fri Jan 13 17:55:05 2006 +++ 25-akpm/drivers/scsi/qla2xxx/qla_sup.c Fri Jan 13 17:55:05 2006 @@ -428,7 +428,7 @@ nvram_data_to_access_addr(uint32_t naddr return FARX_ACCESS_NVRAM_DATA | naddr; } -uint32_t +static uint32_t qla24xx_read_flash_dword(scsi_qla_host_t *ha, uint32_t addr) { int rval; @@ -469,7 +469,7 @@ qla24xx_read_flash_data(scsi_qla_host_t return dwptr; } -int +static int qla24xx_write_flash_dword(scsi_qla_host_t *ha, uint32_t addr, uint32_t data) { int rval; @@ -491,6 +491,8 @@ qla24xx_write_flash_dword(scsi_qla_host_ return rval; } +#if 0 + void qla24xx_get_flash_manufacturer(scsi_qla_host_t *ha, uint8_t *man_id, uint8_t *flash_id) @@ -581,6 +583,8 @@ qla24xx_write_flash_data(scsi_qla_host_t return ret; } +#endif /* 0 */ + uint8_t * qla2x00_read_nvram_data(scsi_qla_host_t *ha, uint8_t *buf, uint32_t naddr, uint32_t bytes) _