From: Andrew Morton - Fix comment layout style - We put a space between `if' and `(' - Remove home-made BUILD_BUG_ON(). Cc: Jan Beulich Signed-off-by: Andrew Morton --- arch/i386/mm/fault.c | 22 +++++++++++++--------- 1 files changed, 13 insertions(+), 9 deletions(-) diff -puN arch/i386/mm/fault.c~i386-actively-synchronize-vmalloc-area-when-registering-certain-callbacks-tidy arch/i386/mm/fault.c --- devel/arch/i386/mm/fault.c~i386-actively-synchronize-vmalloc-area-when-registering-certain-callbacks-tidy 2006-02-23 01:22:56.000000000 -0800 +++ devel-akpm/arch/i386/mm/fault.c 2006-02-23 01:23:07.000000000 -0800 @@ -584,28 +584,32 @@ do_sigbus: #ifndef CONFIG_X86_PAE void vmalloc_sync_all(void) { - /* Note that races in the updates of insync and start aren't problematic: - insync can only get set bits added, and updates to start are only - improving performance (without affecting correctness if undone). */ + /* + * Note that races in the updates of insync and start aren't + * problematic: insync can only get set bits added, and updates to + * start are only improving performance (without affecting correctness + * if undone). + */ static DECLARE_BITMAP(insync, PTRS_PER_PGD); static unsigned long start = TASK_SIZE; unsigned long address; -#define COMPILE_ASSERT(e) ((void)sizeof(char[1 - 2 * !(e)])) - COMPILE_ASSERT(!(TASK_SIZE & ~PGDIR_MASK)); -#undef COMPILE_ASSERT + + BUILD_BUG_ON(TASK_SIZE & ~PGDIR_MASK); for (address = start; address >= TASK_SIZE; address += PGDIR_SIZE) { if (!test_bit(pgd_index(address), insync)) { unsigned long flags; struct page *page; spin_lock_irqsave(&pgd_lock, flags); - for (page = pgd_list; page; page = (struct page *)page->index) - if(!vmalloc_sync_one(page_address(page), address)) { + for (page = pgd_list; page; page = + (struct page *)page->index) + if (!vmalloc_sync_one(page_address(page), + address)) { BUG_ON(page != pgd_list); break; } spin_unlock_irqrestore(&pgd_lock, flags); - if(!page) + if (!page) set_bit(pgd_index(address), insync); } if (address == start && test_bit(pgd_index(address), insync)) _