From: "Theodore Ts'o" It seems counterintuitive that setting the MS_VERBOSE flag actually means "don't be verbose"; but indeed, this is the way things are, and it's consistently defined as such, starting with fs/super.c and propgated down into all of the various filesystem fs/*/super.c which copied that bit of code. Interestingly, mount doesn't have a way of setting the MS_VERBOSE flag, but it *does* have the following: #ifdef MS_SILENT { "quiet", 0, 0, MS_SILENT }, /* be quiet */ { "loud", 0, 1, MS_SILENT }, /* print out messages. */ #endif .... and fs.h doesn't define MS_SILENT, although it does define the MS_VERBOSE flag which has the exact opposite meaning. Signed-off-by: "Theodore Ts'o" Signed-off-by: Andrew Morton --- fs/afs/super.c | 2 +- fs/cifs/cifsfs.c | 2 +- fs/jffs2/super.c | 4 ++-- fs/nfs/inode.c | 4 ++-- fs/super.c | 6 +++--- include/linux/fs.h | 4 +++- init/do_mounts.c | 2 +- 7 files changed, 13 insertions(+), 11 deletions(-) diff -puN fs/afs/super.c~fix-backwards-meaning-of-ms_verbose fs/afs/super.c --- devel/fs/afs/super.c~fix-backwards-meaning-of-ms_verbose 2006-03-16 02:08:43.000000000 -0800 +++ devel-akpm/fs/afs/super.c 2006-03-16 02:08:43.000000000 -0800 @@ -341,7 +341,7 @@ static struct super_block *afs_get_sb(st sb->s_flags = flags; - ret = afs_fill_super(sb, ¶ms, flags & MS_VERBOSE ? 1 : 0); + ret = afs_fill_super(sb, ¶ms, flags & MS_SILENT ? 1 : 0); if (ret < 0) { up_write(&sb->s_umount); deactivate_super(sb); diff -puN fs/cifs/cifsfs.c~fix-backwards-meaning-of-ms_verbose fs/cifs/cifsfs.c --- devel/fs/cifs/cifsfs.c~fix-backwards-meaning-of-ms_verbose 2006-03-16 02:08:43.000000000 -0800 +++ devel-akpm/fs/cifs/cifsfs.c 2006-03-16 02:08:43.000000000 -0800 @@ -476,7 +476,7 @@ cifs_get_sb(struct file_system_type *fs_ sb->s_flags = flags; - rc = cifs_read_super(sb, data, dev_name, flags & MS_VERBOSE ? 1 : 0); + rc = cifs_read_super(sb, data, dev_name, flags & MS_SILENT ? 1 : 0); if (rc) { up_write(&sb->s_umount); deactivate_super(sb); diff -puN fs/jffs2/super.c~fix-backwards-meaning-of-ms_verbose fs/jffs2/super.c --- devel/fs/jffs2/super.c~fix-backwards-meaning-of-ms_verbose 2006-03-16 02:08:43.000000000 -0800 +++ devel-akpm/fs/jffs2/super.c 2006-03-16 02:08:43.000000000 -0800 @@ -152,7 +152,7 @@ static struct super_block *jffs2_get_sb_ sb->s_op = &jffs2_super_operations; sb->s_flags = flags | MS_NOATIME; - ret = jffs2_do_fill_super(sb, data, (flags&MS_VERBOSE)?1:0); + ret = jffs2_do_fill_super(sb, data, flags & MS_SILENT ? 1 : 0); if (ret) { /* Failure case... */ @@ -257,7 +257,7 @@ static struct super_block *jffs2_get_sb( } if (imajor(nd.dentry->d_inode) != MTD_BLOCK_MAJOR) { - if (!(flags & MS_VERBOSE)) /* Yes I mean this. Strangely */ + if (!(flags & MS_SILENT)) printk(KERN_NOTICE "Attempt to mount non-MTD device \"%s\" as JFFS2\n", dev_name); goto out; diff -puN fs/nfs/inode.c~fix-backwards-meaning-of-ms_verbose fs/nfs/inode.c --- devel/fs/nfs/inode.c~fix-backwards-meaning-of-ms_verbose 2006-03-16 02:08:43.000000000 -0800 +++ devel-akpm/fs/nfs/inode.c 2006-03-16 02:08:43.000000000 -0800 @@ -1786,7 +1786,7 @@ static struct super_block *nfs_get_sb(st s->s_flags = flags; - error = nfs_fill_super(s, data, flags & MS_VERBOSE ? 1 : 0); + error = nfs_fill_super(s, data, flags & MS_SILENT ? 1 : 0); if (error) { up_write(&s->s_umount); deactivate_super(s); @@ -2107,7 +2107,7 @@ static struct super_block *nfs4_get_sb(s s->s_flags = flags; - error = nfs4_fill_super(s, data, flags & MS_VERBOSE ? 1 : 0); + error = nfs4_fill_super(s, data, flags & MS_SILENT ? 1 : 0); if (error) { up_write(&s->s_umount); deactivate_super(s); diff -puN fs/super.c~fix-backwards-meaning-of-ms_verbose fs/super.c --- devel/fs/super.c~fix-backwards-meaning-of-ms_verbose 2006-03-16 02:08:43.000000000 -0800 +++ devel-akpm/fs/super.c 2006-03-16 02:08:43.000000000 -0800 @@ -713,7 +713,7 @@ struct super_block *get_sb_bdev(struct f s->s_flags = flags; strlcpy(s->s_id, bdevname(bdev, b), sizeof(s->s_id)); sb_set_blocksize(s, block_size(bdev)); - error = fill_super(s, data, flags & MS_VERBOSE ? 1 : 0); + error = fill_super(s, data, flags & MS_SILENT ? 1 : 0); if (error) { up_write(&s->s_umount); deactivate_super(s); @@ -757,7 +757,7 @@ struct super_block *get_sb_nodev(struct s->s_flags = flags; - error = fill_super(s, data, flags & MS_VERBOSE ? 1 : 0); + error = fill_super(s, data, flags & MS_SILENT ? 1 : 0); if (error) { up_write(&s->s_umount); deactivate_super(s); @@ -786,7 +786,7 @@ struct super_block *get_sb_single(struct return s; if (!s->s_root) { s->s_flags = flags; - error = fill_super(s, data, flags & MS_VERBOSE ? 1 : 0); + error = fill_super(s, data, flags & MS_SILENT ? 1 : 0); if (error) { up_write(&s->s_umount); deactivate_super(s); diff -puN include/linux/fs.h~fix-backwards-meaning-of-ms_verbose include/linux/fs.h --- devel/include/linux/fs.h~fix-backwards-meaning-of-ms_verbose 2006-03-16 02:08:43.000000000 -0800 +++ devel-akpm/include/linux/fs.h 2006-03-16 02:08:43.000000000 -0800 @@ -108,7 +108,9 @@ extern int dir_notify_enable; #define MS_BIND 4096 #define MS_MOVE 8192 #define MS_REC 16384 -#define MS_VERBOSE 32768 +#define MS_VERBOSE 32768 /* War is peace. Verbosity is silence. + MS_VERBOSE is deprecated. */ +#define MS_SILENT 32768 #define MS_POSIXACL (1<<16) /* VFS does not apply the umask */ #define MS_UNBINDABLE (1<<17) /* change to unbindable */ #define MS_PRIVATE (1<<18) /* change to private */ diff -puN init/do_mounts.c~fix-backwards-meaning-of-ms_verbose init/do_mounts.c --- devel/init/do_mounts.c~fix-backwards-meaning-of-ms_verbose 2006-03-16 02:08:43.000000000 -0800 +++ devel-akpm/init/do_mounts.c 2006-03-16 02:08:43.000000000 -0800 @@ -19,7 +19,7 @@ extern int get_filesystem_list(char * bu int __initdata rd_doload; /* 1 = load RAM disk, 0 = don't load */ -int root_mountflags = MS_RDONLY | MS_VERBOSE; +int root_mountflags = MS_RDONLY | MS_SILENT; char * __initdata root_device_name; static char __initdata saved_root_name[64]; _