From: Eugene Teo dev should be validated before it is being used as index to array. Coverity bug #871 Signed-off-by: Eugene Teo Signed-off-by: Andrew Morton --- sound/oss/sb_mixer.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff -puN sound/oss/sb_mixer.c~fix-sb_mixer-use-before-validation sound/oss/sb_mixer.c --- 25/sound/oss/sb_mixer.c~fix-sb_mixer-use-before-validation Fri Mar 17 16:36:56 2006 +++ 25-akpm/sound/oss/sb_mixer.c Fri Mar 17 16:36:56 2006 @@ -273,14 +273,14 @@ int sb_common_mixer_set(sb_devc * devc, int regoffs; unsigned char val; + if ((dev < 0) || (dev >= devc->iomap_sz)) + return -EINVAL; + regoffs = (*devc->iomap)[dev][LEFT_CHN].regno; if (regoffs == 0) return -EINVAL; - if ((dev < 0) || (dev >= devc->iomap_sz)) - return -EINVAL; - val = sb_getmixer(devc, regoffs); change_bits(devc, &val, dev, LEFT_CHN, left); _