From: Jesper Juhl vfree() checks for NULL, no need to do it explicitly. Signed-off-by: Jesper Juhl Acked-by: Zach Brown Signed-off-by: Andrew Morton --- sound/oss/maestro3.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff -puN sound/oss/maestro3.c~maestro3-vfree-null-check-fixup sound/oss/maestro3.c --- 25/sound/oss/maestro3.c~maestro3-vfree-null-check-fixup Fri Feb 24 15:10:33 2006 +++ 25-akpm/sound/oss/maestro3.c Fri Feb 24 15:10:33 2006 @@ -2582,15 +2582,9 @@ static int alloc_dsp_suspendmem(struct m return 0; } -static void free_dsp_suspendmem(struct m3_card *card) -{ - if(card->suspend_mem) - vfree(card->suspend_mem); -} #else #define alloc_dsp_suspendmem(args...) 0 -#define free_dsp_suspendmem(args...) #endif /* @@ -2717,7 +2711,7 @@ out: if(ret) { if(card->iobase) release_region(pci_resource_start(pci_dev, 0), pci_resource_len(pci_dev, 0)); - free_dsp_suspendmem(card); + vfree(card->suspend_mem); if(card->ac97) { unregister_sound_mixer(card->ac97->dev_mixer); kfree(card->ac97); @@ -2760,7 +2754,7 @@ static void m3_remove(struct pci_dev *pc } release_region(card->iobase, 256); - free_dsp_suspendmem(card); + vfree(card->suspend_mem); kfree(card); } devs = NULL; _