From: Eric W. Biederman The removed fields are already set by proc_alloc_inode. Initializing them in proc_alloc_inode implies they need it for proper cleanup. At least ei->pde was not set on all paths making it look like proc_alloc_inode was buggy. So just remove the redundant assignments. Signed-off-by: Eric W. Biederman Signed-off-by: Andrew Morton --- fs/proc/base.c | 2 -- 1 files changed, 2 deletions(-) diff -puN fs/proc/base.c~proc-remove-unnecessary-and-misleading-assignments fs/proc/base.c --- devel/fs/proc/base.c~proc-remove-unnecessary-and-misleading-assignments 2006-02-27 20:58:55.000000000 -0800 +++ devel-akpm/fs/proc/base.c 2006-02-27 20:58:55.000000000 -0800 @@ -1348,7 +1348,6 @@ static struct inode *proc_pid_make_inode /* Common stuff */ ei = PROC_I(inode); - ei->task = NULL; inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME; inode->i_ino = fake_ino(task->pid, ino); @@ -1373,7 +1372,6 @@ out: return inode; out_unlock: - ei->pde = NULL; iput(inode); return NULL; } _