From: Paolo 'Blaisorblade' Giarrusso Noticed this for a compilation-time warning, so I'm fixing it even for TT mode - this is not put_user, but copy_to_user, so we need a pointer to sp, not sp itself (we're trying to write the word pointed to by the "sp" var.). Signed-off-by: Paolo 'Blaisorblade' Giarrusso Cc: Jeff Dike Signed-off-by: Andrew Morton --- arch/um/sys-i386/signal.c | 2 +- arch/um/sys-x86_64/signal.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff -puN arch/um/sys-i386/signal.c~uml-fix-critical-typo-for-tt-mode arch/um/sys-i386/signal.c --- 25/arch/um/sys-i386/signal.c~uml-fix-critical-typo-for-tt-mode Fri Apr 7 15:22:41 2006 +++ 25-akpm/arch/um/sys-i386/signal.c Fri Apr 7 15:22:41 2006 @@ -147,7 +147,7 @@ int copy_sc_to_user_tt(struct sigcontext * delivery. The sp passed in is the original, and this needs * to be restored, so we stick it in separately. */ - err |= copy_to_user(&SC_SP(to), sp, sizeof(sp)); + err |= copy_to_user(&SC_SP(to), &sp, sizeof(sp)); if(from_fp != NULL){ err |= copy_to_user(&to->fpstate, &to_fp, sizeof(to->fpstate)); diff -puN arch/um/sys-x86_64/signal.c~uml-fix-critical-typo-for-tt-mode arch/um/sys-x86_64/signal.c --- 25/arch/um/sys-x86_64/signal.c~uml-fix-critical-typo-for-tt-mode Fri Apr 7 15:22:41 2006 +++ 25-akpm/arch/um/sys-x86_64/signal.c Fri Apr 7 15:22:41 2006 @@ -137,7 +137,7 @@ int copy_sc_to_user_tt(struct sigcontext * delivery. The sp passed in is the original, and this needs * to be restored, so we stick it in separately. */ - err |= copy_to_user(&SC_SP(to), sp, sizeof(sp)); + err |= copy_to_user(&SC_SP(to), &sp, sizeof(sp)); if(from_fp != NULL){ err |= copy_to_user(&to->fpstate, &to_fp, sizeof(to->fpstate)); _