From: Akinobu Mita This patch converts list_add(A, B.prev) to list_add_tail(A, &B) for readability. Acked-by: Karsten Keil Cc: Jan Harkes Acked-by: Jan Kara AOLed-by: David Woodhouse Cc: Sridhar Samudrala Signed-off-by: Akinobu Mita Signed-off-by: Andrew Morton --- drivers/isdn/capi/capi.c | 2 +- fs/coda/psdev.c | 2 +- fs/coda/upcall.c | 2 +- fs/dcache.c | 2 +- fs/dquot.c | 4 ++-- fs/jffs2/compr.c | 4 ++-- net/sctp/outqueue.c | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) diff -puN drivers/isdn/capi/capi.c~use-list_add_tail-instead-of-list_add drivers/isdn/capi/capi.c --- devel/drivers/isdn/capi/capi.c~use-list_add_tail-instead-of-list_add 2006-04-10 01:22:55.000000000 -0700 +++ devel-akpm/drivers/isdn/capi/capi.c 2006-04-10 01:22:55.000000000 -0700 @@ -238,7 +238,7 @@ static struct capiminor *capiminor_alloc if (minor < capi_ttyminors) { mp->minor = minor; - list_add(&mp->list, p->list.prev); + list_add_tail(&mp->list, &p->list); } } write_unlock_irqrestore(&capiminor_list_lock, flags); diff -puN fs/coda/psdev.c~use-list_add_tail-instead-of-list_add fs/coda/psdev.c --- devel/fs/coda/psdev.c~use-list_add_tail-instead-of-list_add 2006-04-10 01:22:55.000000000 -0700 +++ devel-akpm/fs/coda/psdev.c 2006-04-10 01:22:55.000000000 -0700 @@ -259,7 +259,7 @@ static ssize_t coda_psdev_read(struct fi /* If request was not a signal, enqueue and don't free */ if (!(req->uc_flags & REQ_ASYNC)) { req->uc_flags |= REQ_READ; - list_add(&(req->uc_chain), vcp->vc_processing.prev); + list_add_tail(&(req->uc_chain), &vcp->vc_processing); goto out; } diff -puN fs/coda/upcall.c~use-list_add_tail-instead-of-list_add fs/coda/upcall.c --- devel/fs/coda/upcall.c~use-list_add_tail-instead-of-list_add 2006-04-10 01:22:55.000000000 -0700 +++ devel-akpm/fs/coda/upcall.c 2006-04-10 01:22:55.000000000 -0700 @@ -725,7 +725,7 @@ static int coda_upcall(struct coda_sb_in ((union inputArgs *)buffer)->ih.unique = req->uc_unique; /* Append msg to pending queue and poke Venus. */ - list_add(&(req->uc_chain), vcommp->vc_pending.prev); + list_add_tail(&(req->uc_chain), &vcommp->vc_pending); wake_up_interruptible(&vcommp->vc_waitq); /* We can be interrupted while we wait for Venus to process diff -puN fs/dcache.c~use-list_add_tail-instead-of-list_add fs/dcache.c --- devel/fs/dcache.c~use-list_add_tail-instead-of-list_add 2006-04-10 01:22:55.000000000 -0700 +++ devel-akpm/fs/dcache.c 2006-04-10 01:22:55.000000000 -0700 @@ -638,7 +638,7 @@ resume: * of the unused list for prune_dcache */ if (!atomic_read(&dentry->d_count)) { - list_add(&dentry->d_lru, dentry_unused.prev); + list_add_tail(&dentry->d_lru, &dentry_unused); dentry_stat.nr_unused++; found++; } diff -puN fs/dquot.c~use-list_add_tail-instead-of-list_add fs/dquot.c --- devel/fs/dquot.c~use-list_add_tail-instead-of-list_add 2006-04-10 01:22:55.000000000 -0700 +++ devel-akpm/fs/dquot.c 2006-04-10 01:22:55.000000000 -0700 @@ -250,7 +250,7 @@ static inline struct dquot *find_dquot(u /* Add a dquot to the tail of the free list */ static inline void put_dquot_last(struct dquot *dquot) { - list_add(&dquot->dq_free, free_dquots.prev); + list_add_tail(&dquot->dq_free, &free_dquots); dqstats.free_dquots++; } @@ -266,7 +266,7 @@ static inline void put_inuse(struct dquo { /* We add to the back of inuse list so we don't have to restart * when traversing this list and we block */ - list_add(&dquot->dq_inuse, inuse_list.prev); + list_add_tail(&dquot->dq_inuse, &inuse_list); dqstats.allocated_dquots++; } diff -puN fs/jffs2/compr.c~use-list_add_tail-instead-of-list_add fs/jffs2/compr.c --- devel/fs/jffs2/compr.c~use-list_add_tail-instead-of-list_add 2006-04-10 01:22:55.000000000 -0700 +++ devel-akpm/fs/jffs2/compr.c 2006-04-10 01:22:55.000000000 -0700 @@ -231,7 +231,7 @@ int jffs2_register_compressor(struct jff list_for_each_entry(this, &jffs2_compressor_list, list) { if (this->priority < comp->priority) { - list_add(&comp->list, this->list.prev); + list_add_tail(&comp->list, &this->list); goto out; } } @@ -394,7 +394,7 @@ reinsert: list_del(&comp->list); list_for_each_entry(this, &jffs2_compressor_list, list) { if (this->priority < comp->priority) { - list_add(&comp->list, this->list.prev); + list_add_tail(&comp->list, &this->list); spin_unlock(&jffs2_compressor_list_lock); return 0; } diff -puN net/sctp/outqueue.c~use-list_add_tail-instead-of-list_add net/sctp/outqueue.c --- devel/net/sctp/outqueue.c~use-list_add_tail-instead-of-list_add 2006-04-10 01:22:55.000000000 -0700 +++ devel-akpm/net/sctp/outqueue.c 2006-04-10 01:22:55.000000000 -0700 @@ -370,7 +370,7 @@ static void sctp_insert_list(struct list lchunk = list_entry(pos, struct sctp_chunk, transmitted_list); ltsn = ntohl(lchunk->subh.data_hdr->tsn); if (TSN_lt(ntsn, ltsn)) { - list_add(new, pos->prev); + list_add_tail(new, pos); done = 1; break; } _