From: Roman Zippel The AGP default doesn't work well with other selects, so use a select for GART_IOMMU as well. Remove a redundant default for SWIOTLB as well. Signed-off-by: Roman Zippel Cc: Andi Kleen Cc: Dave Jones Cc: Dave Airlie Signed-off-by: Andrew Morton --- arch/x86_64/Kconfig | 5 ++--- drivers/char/agp/Kconfig | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff -puN arch/x86_64/Kconfig~x86_64-use-select-for-gart_iommu-to-enable-agp arch/x86_64/Kconfig --- devel/arch/x86_64/Kconfig~x86_64-use-select-for-gart_iommu-to-enable-agp 2006-04-14 23:41:54.000000000 -0700 +++ devel-akpm/arch/x86_64/Kconfig 2006-04-14 23:41:54.000000000 -0700 @@ -399,6 +399,7 @@ config GART_IOMMU bool "K8 GART IOMMU support" default y select SWIOTLB + select AGP depends on PCI help Support for hardware IOMMU in AMD's Opteron/Athlon64 Processors @@ -429,11 +430,9 @@ config CALGARY_IOMMU Normally the kernel will make the right choice by itself. If unsure, say Y. -# need this always enabled with GART_IOMMU for the VIA workaround +# need this always selected by GART_IOMMU for the VIA workaround config SWIOTLB bool - default y - depends on GART_IOMMU config X86_MCE bool "Machine check support" if EMBEDDED diff -puN drivers/char/agp/Kconfig~x86_64-use-select-for-gart_iommu-to-enable-agp drivers/char/agp/Kconfig --- devel/drivers/char/agp/Kconfig~x86_64-use-select-for-gart_iommu-to-enable-agp 2006-04-14 23:41:54.000000000 -0700 +++ devel-akpm/drivers/char/agp/Kconfig 2006-04-14 23:41:54.000000000 -0700 @@ -1,7 +1,6 @@ config AGP - tristate "/dev/agpgart (AGP Support)" if !GART_IOMMU + tristate "/dev/agpgart (AGP Support)" depends on ALPHA || IA64 || PPC || X86 - default y if GART_IOMMU ---help--- AGP (Accelerated Graphics Port) is a bus system mainly used to connect graphics cards to the rest of the system. _