From jesper.juhl@gmail.com Sun Apr 23 10:58:42 2006 From: Jesper Juhl To: linux-kernel@vger.kernel.org Subject: USB: Resource leak fix for whiteheat driver Date: Sun, 23 Apr 2006 19:59:23 +0200 Cc: Greg Kroah-Hartman , Stuart MacDonald , Jesper Juhl Content-Disposition: inline Message-Id: <200604231959.23877.jesper.juhl@gmail.com> We may return from drivers/usb/serial/whiteheat.c::whiteheat_attach() without freeing `result' if we leave via the no_firmware: label. Spotted by the coverity checker as #670 Signed-off-by: Jesper Juhl Signed-off-by: Greg Kroah-Hartman --- drivers/usb/serial/whiteheat.c | 1 + 1 file changed, 1 insertion(+) --- gregkh-2.6.orig/drivers/usb/serial/whiteheat.c +++ gregkh-2.6/drivers/usb/serial/whiteheat.c @@ -508,6 +508,7 @@ no_firmware: err("%s: Unable to retrieve firmware version, try replugging\n", serial->type->description); err("%s: If the firmware is not running (status led not blinking)\n", serial->type->description); err("%s: please contact support@connecttech.com\n", serial->type->description); + kfree(result); return -ENODEV; no_command_private: