From: NeilBrown When "mdadm --grow /dev/mdX --bitmap=none" is used to remove a filebacked bitmap, the bitmap was disconnected from the array, but the file wasn't closed (until the array was stopped). The file also wasn't closed if adding the bitmap file failed. Signed-off-by: Neil Brown Signed-off-by: Andrew Morton --- drivers/md/md.c | 7 +++++-- 1 files changed, 5 insertions(+), 2 deletions(-) diff -puN drivers/md/md.c~md-bitmap-fix-online-removal-of-file-backed-bitmaps drivers/md/md.c --- 25/drivers/md/md.c~md-bitmap-fix-online-removal-of-file-backed-bitmaps Fri May 12 10:24:39 2006 +++ 25-akpm/drivers/md/md.c Fri May 12 10:24:39 2006 @@ -3588,10 +3588,13 @@ static int set_bitmap_file(mddev_t *mdde mddev->pers->quiesce(mddev, 1); if (fd >= 0) err = bitmap_create(mddev); - if (fd < 0 || err) + if (fd < 0 || err) { bitmap_destroy(mddev); + fd = -1; /* make sure to put the file */ + } mddev->pers->quiesce(mddev, 0); - } else if (fd < 0) { + } + if (fd < 0) { if (mddev->bitmap_file) fput(mddev->bitmap_file); mddev->bitmap_file = NULL; _