From: Balbir Singh <balbir@in.ibm.com>

On Mon, May 08, 2006 at 02:31:39PM -0700, Andrew Morton wrote:
> Balbir Singh <balbir@in.ibm.com> wrote:
> >
> > +
> > +	if ((rc = genl_register_ops(&family, &taskstats_ops)) < 0)
> > +		goto err;
>
> 	rc = genl_register_ops(&family, &taskstats_ops);
> 	if (rc < 0)
> 		goto err;
>
> please.

Sure, here you go Andrew

I have updated the coding style as per your suggestion

	Balbir Singh,
	Linux Technology Center,
	IBM Software Labs

Changelog

1. Split the complex if condition into
   a. function call
   b. check return status for error

Signed-off-by: Balbir Singh <balbir@in.ibm.com>
Signed-off-by: Shailabh Nagar <nagar@watson.ibm.com>
Cc: Jes Sorensen <jes@sgi.com>
Cc: Peter Chubb <peterc@gelato.unsw.edu.au>
Cc: Erich Focht <efocht@ess.nec.de>
Cc: Levent Serinol <lserinol@gmail.com>
Cc: Jay Lan <jlan@engr.sgi.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 kernel/taskstats.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -puN kernel/taskstats.c~per-task-delay-accounting-taskstats-interface-fix-1 kernel/taskstats.c
--- devel/kernel/taskstats.c~per-task-delay-accounting-taskstats-interface-fix-1	2006-05-11 09:23:59.000000000 -0700
+++ devel-akpm/kernel/taskstats.c	2006-05-11 09:23:59.000000000 -0700
@@ -312,7 +312,8 @@ static int __init taskstats_init(void)
 		return rc;
 	family_registered = 1;
 
-	if ((rc = genl_register_ops(&family, &taskstats_ops)) < 0)
+	rc = genl_register_ops(&family, &taskstats_ops);
+	if (rc < 0)
 		goto err;
 
 	return 0;
_