From: Oleg Nesterov We should keep the value of old_leader->tasks.next in de_thread, otherwise we can't do for_each_process/do_each_thread without tasklist_lock held. Signed-off-by: Oleg Nesterov Cc: "Eric W. Biederman" Signed-off-by: Andrew Morton --- fs/exec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff -puN fs/exec.c~de_thread-fix-lockless-do_each_thread fs/exec.c --- devel/fs/exec.c~de_thread-fix-lockless-do_each_thread 2006-05-19 16:01:37.000000000 -0700 +++ devel-akpm/fs/exec.c 2006-05-19 16:01:37.000000000 -0700 @@ -707,7 +707,7 @@ static int de_thread(struct task_struct attach_pid(current, PIDTYPE_PID, current->pid); attach_pid(current, PIDTYPE_PGID, current->signal->pgrp); attach_pid(current, PIDTYPE_SID, current->signal->session); - list_add_tail_rcu(¤t->tasks, &init_task.tasks); + list_replace_rcu(&leader->tasks, ¤t->tasks); current->group_leader = current; leader->group_leader = current; @@ -715,7 +715,6 @@ static int de_thread(struct task_struct /* Reduce leader to a thread */ detach_pid(leader, PIDTYPE_PGID); detach_pid(leader, PIDTYPE_SID); - list_del_init(&leader->tasks); current->exit_signal = SIGCHLD; _