From: Andrew Morton kernel/audit.c: In function 'kauditd_thread': kernel/audit.c:367: warning: no return statement in function returning non-void Might as well test kthread_should_stop(), although it's not very pointful at present. The code which starts this thread looks racy - the kernel could start multiple threads. Cc: Al Viro Signed-off-by: Andrew Morton --- kernel/audit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -puN kernel/audit.c~kauditd_thread-warning-fix kernel/audit.c --- devel/kernel/audit.c~kauditd_thread-warning-fix 2006-05-20 00:34:38.000000000 -0700 +++ devel-akpm/kernel/audit.c 2006-05-20 00:35:20.000000000 -0700 @@ -335,7 +335,7 @@ static int kauditd_thread(void *dummy) { struct sk_buff *skb; - while (1) { + while (!kthread_should_stop()) { skb = skb_dequeue(&audit_skb_queue); wake_up(&audit_backlog_wait); if (skb) { @@ -364,6 +364,7 @@ static int kauditd_thread(void *dummy) remove_wait_queue(&kauditd_wait, &wait); } } + return 0; } int audit_send_list(void *_dest) _