From: Florin Malita <fmalita@gmail.com>

Assigning the result of posix_acl_to_xattr() to an unsigned data type
(size/size_t) obscures possible errors.

Coverity CID: 1206.

Signed-off-by: Florin Malita <fmalita@gmail.com>
Acked-by: NeilBrown <neilb@suse.de>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 fs/nfsd/vfs.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff -puN fs/nfsd/vfs.c~nfsd-sign-conversion-obscuring-errors-in-nfsd_set_posix_acl fs/nfsd/vfs.c
--- devel/fs/nfsd/vfs.c~nfsd-sign-conversion-obscuring-errors-in-nfsd_set_posix_acl	2006-05-15 21:39:14.000000000 -0700
+++ devel-akpm/fs/nfsd/vfs.c	2006-05-15 21:39:14.000000000 -0700
@@ -1922,11 +1922,10 @@ nfsd_set_posix_acl(struct svc_fh *fhp, i
 		value = kmalloc(size, GFP_KERNEL);
 		if (!value)
 			return -ENOMEM;
-		size = posix_acl_to_xattr(acl, value, size);
-		if (size < 0) {
-			error = size;
+		error = posix_acl_to_xattr(acl, value, size);
+		if (error < 0)
 			goto getout;
-		}
+		size = error;
 	} else
 		size = 0;
 
_