From: Jesper Juhl In sw_connect we leak 'buf' and 'idbuf' when we do not leave via one of the fail* labels. This was spotted by the coverity checker. This patch fixes the memory leak. Signed-off-by: Jesper Juhl Cc: Dmitry Torokhov Signed-off-by: Andrew Morton --- drivers/input/joystick/sidewinder.c | 2 ++ 1 files changed, 2 insertions(+) diff -puN drivers/input/joystick/sidewinder.c~fix-mem-leak-in-sidewinder-driver drivers/input/joystick/sidewinder.c --- devel/drivers/input/joystick/sidewinder.c~fix-mem-leak-in-sidewinder-driver 2006-05-10 21:55:46.000000000 -0700 +++ devel-akpm/drivers/input/joystick/sidewinder.c 2006-05-10 21:55:46.000000000 -0700 @@ -776,6 +776,8 @@ static int sw_connect(struct gameport *g goto fail4; } + kfree(buf); + kfree(idbuf); return 0; fail4: input_free_device(sw->dev[i]); _