From: Andrew Morton - coding style touchups - remove unneeded casts of void* - correct type for printk()ing pointers Cc: Jaya Kumar Cc: "Brown, Len" Cc: Dmitry Torokhov Cc: "Yu, Luming" Signed-off-by: Andrew Morton --- drivers/acpi/atlas_acpi.c | 12 ++++++------ acpi/Kconfig | 0 acpi/Makefile | 0 3 files changed, 6 insertions(+), 6 deletions(-) diff -puN drivers/acpi/atlas_acpi.c~acpi-atlas-acpi-driver-v2-tidy drivers/acpi/atlas_acpi.c --- devel/drivers/acpi/atlas_acpi.c~acpi-atlas-acpi-driver-v2-tidy 2006-05-22 19:44:33.000000000 -0700 +++ devel-akpm/drivers/acpi/atlas_acpi.c 2006-05-22 19:44:33.000000000 -0700 @@ -56,7 +56,8 @@ static int atlas_setup_input(void) input_dev = input_allocate_device(); if (!input_dev) { - printk(KERN_ERR "atlas: insufficient mem to allocate input device\n"); + printk(KERN_ERR "atlas: insufficient mem to allocate input " + "device\n"); return -ENOMEM; } @@ -108,20 +109,19 @@ static acpi_status acpi_atlas_button_set static acpi_status acpi_atlas_button_handler(u32 function, acpi_physical_address address, - u32 bit_width, acpi_integer * value, + u32 bit_width, acpi_integer *value, void *handler_context, void *region_context) { acpi_status status; - struct acpi_device *dev; + struct acpi_device *dev = handler_context; - dev = (struct acpi_device *) handler_context; if (function == ACPI_WRITE) { status = acpi_bus_generate_event(dev, 0x80, address); atlas_input_report((u8) address); } else { printk(KERN_WARNING "atlas: shrugged on unexpected function" - ":function=%x,address=%x,value=%x\n", - function, (u32)address, (u32)*value); + ":function=%x,address=%lx,value=%x\n", + function, (unsigned long)address, (u32)*value); status = -EINVAL; } diff -puN drivers/acpi/Kconfig~acpi-atlas-acpi-driver-v2-tidy drivers/acpi/Kconfig diff -puN drivers/acpi/Makefile~acpi-atlas-acpi-driver-v2-tidy drivers/acpi/Makefile _