From khali@linux-fr.org Mon Jun 12 12:49:39 2006 Date: Mon, 12 Jun 2006 21:49:36 +0200 From: Jean Delvare To: Greg KH Cc: LM Sensors Subject: [PATCH 06/14] i2c-i801: Fix block transaction poll loops Message-Id: <20060612214936.d81fd1b9.khali@linux-fr.org> Content-Disposition: inline; filename=i2c-i801-01-fix-block-transaction-poll-loops.patch i2c-i801: Fix block transaction poll loops Two of the three poll loops have the poll and sleep swapped, causing an extra sleep to occur after the polled condition is fulfilled. In practice, this doubles the amount of sleep time for every block transaction. Signed-off-by: Jean Delvare Signed-off-by: Greg Kroah-Hartman --- drivers/i2c/busses/i2c-i801.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- gregkh-2.6.orig/drivers/i2c/busses/i2c-i801.c +++ gregkh-2.6/drivers/i2c/busses/i2c-i801.c @@ -334,8 +334,8 @@ static int i801_block_transaction(union /* We will always wait for a fraction of a second! */ timeout = 0; do { - temp = inb_p(SMBHSTSTS); msleep(1); + temp = inb_p(SMBHSTSTS); } while ((!(temp & 0x80)) && (timeout++ < MAX_TIMEOUT)); @@ -393,8 +393,8 @@ static int i801_block_transaction(union /* wait for INTR bit as advised by Intel */ timeout = 0; do { - temp = inb_p(SMBHSTSTS); msleep(1); + temp = inb_p(SMBHSTSTS); } while ((!(temp & 0x02)) && (timeout++ < MAX_TIMEOUT));