From: Eric Sesterhenn coverity found two needless checks in vfs_inode.c (cid #1165 and #1164) In both cases inode is always NULL when we goto error; either because it is still initialized to NULL or is set to NULL explicitly. This patch simply removes these checks to save some code. Signed-off-by: Eric Sesterhenn Acked-by: Eric Van Hensbergen Cc: Ron Minnich Cc: Latchesar Ionkov Signed-off-by: Andrew Morton --- fs/9p/vfs_inode.c | 6 ------ 1 file changed, 6 deletions(-) diff -puN fs/9p/vfs_inode.c~remove-needless-checks-in-fs-9p-vfs_inodec fs/9p/vfs_inode.c --- a/fs/9p/vfs_inode.c~remove-needless-checks-in-fs-9p-vfs_inodec +++ a/fs/9p/vfs_inode.c @@ -530,9 +530,6 @@ error: if (vfid) v9fs_fid_destroy(vfid); - if (inode) - iput(inode); - return err; } @@ -1174,9 +1171,6 @@ error: if (vfid) v9fs_fid_destroy(vfid); - if (inode) - iput(inode); - return err; } _