From: Jim Cromie Hmm. Im somewhat ambivalent about this patch, since with it, driver wont build for vanilla 17 or older. Its also only 1/2 of your suggestion - when I tried it, I was building against vanilla 17, and asm/uaccess.h cause compilation failure. Looking back, Im perplexed as to why linux/io.h didnt cause same failure ?!? use linux/io.h rather than asm/io.h Signed-off-by: Jim Cromie Signed-off-by: Andrew Morton --- drivers/char/pc8736x_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/char/pc8736x_gpio.c~chardev-gpio-for-scx200-pc-8736x-replace-spinlocks-include-linux-ioh drivers/char/pc8736x_gpio.c --- a/drivers/char/pc8736x_gpio.c~chardev-gpio-for-scx200-pc-8736x-replace-spinlocks-include-linux-ioh +++ a/drivers/char/pc8736x_gpio.c @@ -15,12 +15,12 @@ #include #include #include +#include #include #include #include #include #include -#include #define DEVNAME "pc8736x_gpio" _