From: Eric Sesterhenn Spotted by coverity (id #539), we should use the define with which the array is defined. We use min_agc as index for e1000_igp_2_cable_length_table[IGP02E1000_AGC_LENGTH_TABLE_SIZE] This patch also adds the -1 to make it safe so that we dont read past the end of the array. Signed-off-by: Eric Sesterhenn Cc: John Ronciak Cc: Jesse Brandeburg Cc: Jeff Kirsher Cc: Auke Kok Cc: Jeff Garzik Signed-off-by: Andrew Morton --- drivers/net/e1000/e1000_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/net/e1000/e1000_hw.c~typo-in-drivers-net-e1000-e1000_hwc drivers/net/e1000/e1000_hw.c --- a/drivers/net/e1000/e1000_hw.c~typo-in-drivers-net-e1000-e1000_hwc +++ a/drivers/net/e1000/e1000_hw.c @@ -6012,7 +6012,7 @@ e1000_get_cable_length(struct e1000_hw * { int32_t ret_val; uint16_t agc_value = 0; - uint16_t cur_agc, min_agc = IGP01E1000_AGC_LENGTH_TABLE_SIZE; + uint16_t cur_agc, min_agc = IGP02E1000_AGC_LENGTH_TABLE_SIZE - 1; uint16_t max_agc = 0; uint16_t i, phy_data; uint16_t cable_length; _