From: "Eric W. Biederman" Rajesh Shah writes: > On Tue, Jun 20, 2006 at 04:24:35PM -0600, Eric W. Biederman wrote: >> >> The primary aim of this patch is to remove maintenances problems caused >> by the irq infrastructure. The two big issues I address are an >> artificially small cap on the number of irqs, and that MSI assumes >> vector == irq. My primary focus is on x86_64 but I have touched >> other architectures where necessary to keep them from breaking. >> > The MSI portions of this patchset is similar to the MSI cleanup > I was working on. I'll drop my patchkit and instead comment on > the relevant patches in this kit. > > I got a couple of minor compile errors on i386 (kernel/io_apic.c). > I fixed them up by hand and the resulting kernel booted and > worked with MSI in the limited testing I've done so far. Somewhere in the final round of cleanups I missed these two one liners. This is what it takes to fix the i386 build. Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Benjamin Herrenschmidt Cc: Rajesh Shah Cc: Andi Kleen Cc: "Protasevich, Natalie" Cc: "Luck, Tony" Signed-off-by: Andrew Morton --- arch/i386/kernel/io_apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN arch/i386/kernel/io_apic.c~genirq-i386-irq-dynamic-irq-support-fix arch/i386/kernel/io_apic.c --- a/arch/i386/kernel/io_apic.c~genirq-i386-irq-dynamic-irq-support-fix +++ a/arch/i386/kernel/io_apic.c @@ -2534,7 +2534,7 @@ void destroy_irq(unsigned int irq) unsigned long flags; unsigned int vector; - dynmic_irq_cleanup(irq); + dynamic_irq_cleanup(irq); spin_lock_irqsave(&vector_lock, flags); vector = irq_vector[irq]; _