From: Josh Triplett Commit 398c53a757702e1e3a7a2c24860c7ad26acb53ed (in the historical GIT tree) moved the lock_kernel() in coda_open after the allocation of a coda_file_info struct, but left an unlock_kernel() in the allocation failure error path; remove it. Signed-off-by: Josh Triplett Acked-by: Jan Harkes Signed-off-by: Andrew Morton --- fs/coda/file.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff -puN fs/coda/file.c~remove-incorrect-unlock_kernel-from-allocation fs/coda/file.c --- a/fs/coda/file.c~remove-incorrect-unlock_kernel-from-allocation +++ a/fs/coda/file.c @@ -136,10 +136,8 @@ int coda_open(struct inode *coda_inode, coda_vfs_stat.open++; cfi = kmalloc(sizeof(struct coda_file_info), GFP_KERNEL); - if (!cfi) { - unlock_kernel(); + if (!cfi) return -ENOMEM; - } lock_kernel(); _