From: Andrew Morton arch/x86_64/kernel/machine_kexec.c: In function 'setup_crashkernel': arch/x86_64/kernel/machine_kexec.c:245: error: 'from' undeclared (first use in this function) Cc: Rusty Russell Cc: Andi Kleen Signed-off-by: Andrew Morton --- arch/x86_64/kernel/machine_kexec.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff -puN arch/x86_64/kernel/machine_kexec.c~x86_64-mm-early-param-fix arch/x86_64/kernel/machine_kexec.c --- a/arch/x86_64/kernel/machine_kexec.c~x86_64-mm-early-param-fix +++ a/arch/x86_64/kernel/machine_kexec.c @@ -236,14 +236,16 @@ NORET_TYPE void machine_kexec(struct kim static int __init setup_crashkernel(char *arg) { unsigned long size, base; - char *end; + char *p; + if (!arg) return -EINVAL; - size = memparse(arg, &end); - if (arg == end) + size = memparse(arg, &p); + if (p == arg) return -EINVAL; - if (*from == '@') { - base = memparse(from+1, &from); + + if (*p == '@') { + base = memparse(p + 1, &p); /* FIXME: Do I want a sanity check to validate the * memory range? Yes you do, but it's too early for * e820 -AK */ @@ -253,4 +255,3 @@ static int __init setup_crashkernel(char return 0; } early_param("crashkernel=", setup_crashkernel); - _