From: Peter Zijlstra Smallish cleanup to install_page(), could save a memory read (haven't checked the asm output) and sure looks nicer. Signed-off-by: Peter Zijlstra Cc: Hugh Dickins Signed-off-by: Andrew Morton --- mm/fremap.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN mm/fremap.c~mm-small-cleanup-of-install_page mm/fremap.c --- a/mm/fremap.c~mm-small-cleanup-of-install_page +++ a/mm/fremap.c @@ -79,9 +79,9 @@ int install_page(struct mm_struct *mm, s inc_mm_counter(mm, file_rss); flush_icache_page(vma, page); - set_pte_at(mm, addr, pte, mk_pte(page, prot)); + pte_val = mk_pte(page, prot); + set_pte_at(mm, addr, pte, pte_val); page_add_file_rmap(page); - pte_val = *pte; update_mmu_cache(vma, addr, pte_val); lazy_mmu_prot_update(pte_val); err = 0; _