From david-b@pacbell.net Tue Aug 8 23:58:38 2006 From: David Brownell To: Greg KH Subject: USB: usbtest.c: unsigned retval makes ctrl_out return 0 in case of error Date: Tue, 8 Aug 2006 23:31:40 -0700 Cc: Orjan Friberg Content-Disposition: inline Message-Id: <200608082331.41000.david-b@pacbell.net> From: Orjan Friberg In my quest to try and figure out why test 14 (control write) doesn't work with my EZ-USB board, I noticed that sometimes testusb reported no error even though the kernel log complained "byte 0 is 0 not 2" etc. Signed-off-by: David Brownell Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/usbtest.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- gregkh-2.6.orig/drivers/usb/misc/usbtest.c +++ gregkh-2.6/drivers/usb/misc/usbtest.c @@ -1242,11 +1242,12 @@ done: static int ctrl_out (struct usbtest_dev *dev, unsigned count, unsigned length, unsigned vary) { - unsigned i, j, len, retval; + unsigned i, j, len; + int retval; u8 *buf; char *what = "?"; struct usb_device *udev; - + if (length < 1 || length > 0xffff || vary >= length) return -EINVAL;