From: Christoph Lameter mm/migrate.c: In function 'migrate_page_move_mapping': mm/migrate.c:313: warning: passing argument 1 of 'radix_tree_deref_slot' from incompatible pointer type mm/migrate.c:329: warning: passing argument 1 of 'radix_tree_replace_slot' from incompatible pointer type Cc: Christoph Lameter Cc: Nick Piggin Cc: Lee Schermerhorn Signed-off-by: Andrew Morton --- mm/migrate.c | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff -puN mm/migrate.c~cleanup-radix_tree_derefreplace_slot-calling-conventions-warning-fixes mm/migrate.c --- a/mm/migrate.c~cleanup-radix_tree_derefreplace_slot-calling-conventions-warning-fixes +++ a/mm/migrate.c @@ -294,7 +294,7 @@ out: static int migrate_page_move_mapping(struct address_space *mapping, struct page *newpage, struct page *page) { - struct page **radix_pointer; + void **pslot; if (!mapping) { /* Anonymous page */ @@ -305,12 +305,11 @@ static int migrate_page_move_mapping(str write_lock_irq(&mapping->tree_lock); - radix_pointer = (struct page **)radix_tree_lookup_slot( - &mapping->page_tree, - page_index(page)); + pslot = radix_tree_lookup_slot(&mapping->page_tree, + page_index(page)); if (page_count(page) != 2 + !!PagePrivate(page) || - radix_tree_deref_slot(radix_pointer) != page) { + (struct page *)radix_tree_deref_slot(pslot) != page) { write_unlock_irq(&mapping->tree_lock); return -EAGAIN; } @@ -318,7 +317,7 @@ static int migrate_page_move_mapping(str /* * Now we know that no one else is looking at the page. */ - get_page(newpage); + get_page(newpage); /* add cache reference */ #ifdef CONFIG_SWAP if (PageSwapCache(page)) { SetPageSwapCache(newpage); @@ -326,8 +325,14 @@ static int migrate_page_move_mapping(str } #endif - radix_tree_replace_slot(radix_pointer, newpage); + radix_tree_replace_slot(pslot, newpage); + + /* + * Drop cache reference from old page. + * We know this isn't the last reference. + */ __put_page(page); + write_unlock_irq(&mapping->tree_lock); return 0; _