From khali@linux-fr.org Mon Aug 28 05:26:25 2006 Date: Mon, 28 Aug 2006 14:26:22 +0200 From: Jean Delvare To: Greg KH Cc: LM Sensors Subject: [PATCH 06/14] it87: Prevent overflow on fan clock divider write Message-Id: <20060828142622.4e6c9492.khali@linux-fr.org> Content-Disposition: inline; filename=hwmon-it87-div-to-reg-overflow.patch it87: Prevent overflow on fan clock divider write The highest possible clock divider for fan1 and fan2 is 128. Signed-off-by: Jean Delvare Signed-off-by: Greg Kroah-Hartman --- drivers/hwmon/it87.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- gregkh-2.6.orig/drivers/hwmon/it87.c +++ gregkh-2.6/drivers/hwmon/it87.c @@ -198,7 +198,7 @@ static inline u16 FAN16_TO_REG(long rpm) static int DIV_TO_REG(int val) { int answer = 0; - while ((val >>= 1) != 0) + while (answer < 7 && (val >>= 1)) answer++; return answer; } @@ -563,7 +563,7 @@ static ssize_t set_fan_div(struct device struct i2c_client *client = to_i2c_client(dev); struct it87_data *data = i2c_get_clientdata(client); - int val = simple_strtol(buf, NULL, 10); + unsigned long val = simple_strtoul(buf, NULL, 10); int i, min[3]; u8 old;