From: Jeff Garzik gcc emits the following warning: drivers/atm/firestream.c: In function ‘fs_open’: drivers/atm/firestream.c:870: warning: ‘tmc0’ may be used uninitialized in this function This indicates a real bug. We should check make_rate() return value for potential errors. Signed-off-by: Jeff Garzik Cc: chas williams Signed-off-by: Andrew Morton --- drivers/atm/firestream.c | 4 ++++ 1 files changed, 4 insertions(+) diff -puN drivers/atm/firestream.c~atm-firestream-handle-thrown-error drivers/atm/firestream.c --- a/drivers/atm/firestream.c~atm-firestream-handle-thrown-error +++ a/drivers/atm/firestream.c @@ -1002,6 +1002,10 @@ static int fs_open(struct atm_vcc *atm_v r = ROUND_UP; } error = make_rate (pcr, r, &tmc0, NULL); + if (error) { + kfree(tc); + return error; + } } fs_dprintk (FS_DEBUG_OPEN, "pcr = %d.\n", pcr); } _