From: Jeff Mahoney Callers after reiserfs_init_bitmap_cache() expect errval to contain -EINVAL until much later. If a condition fails before errval is reset later, reiserfs_fill_super() will mistakenly return 0, causing an Oops in do_add_mount(). This patch resets errval to -EINVAL after the call. I view this as a temporary fix and real error codes should be used throughout reiserfs_fill_super(). Signed-off-by: Jeff Mahoney Signed-off-by: Andrew Morton --- fs/reiserfs/super.c | 1 + 1 files changed, 1 insertion(+) diff -puN fs/reiserfs/super.c~reiserfs-reset-errval-after-initializing-bitmap-cache fs/reiserfs/super.c --- a/fs/reiserfs/super.c~reiserfs-reset-errval-after-initializing-bitmap-cache +++ a/fs/reiserfs/super.c @@ -1619,6 +1619,7 @@ static int reiserfs_fill_super(struct su "jmacd-8: reiserfs_fill_super: unable to read bitmap"); goto error; } + errval = -EINVAL; #ifdef CONFIG_REISERFS_CHECK SWARN(silent, s, "CONFIG_REISERFS_CHECK is set ON"); SWARN(silent, s, "- it is slow mode for debugging."); _