From: Amol Lad ioremap must be balanced by an iounmap and failing to do so can result in a memory leak. Signed-off-by: Amol Lad Cc: "Antonino A. Daplas" Cc: Benjamin Herrenschmidt Signed-off-by: Andrew Morton --- drivers/video/aty/atyfb_base.c | 8 ++++++++ 1 files changed, 8 insertions(+) diff -puN drivers/video/aty/atyfb_base.c~ioremap-balanced-with-iounmap-for-drivers-video-atyfb_base drivers/video/aty/atyfb_base.c --- a/drivers/video/aty/atyfb_base.c~ioremap-balanced-with-iounmap-for-drivers-video-atyfb_base +++ a/drivers/video/aty/atyfb_base.c @@ -3527,6 +3527,10 @@ static int __devinit atyfb_setup_generic atyfb_setup_generic_fail: iounmap(par->ati_regbase); par->ati_regbase = NULL; + if (info->screen_base) { + iounmap(info->screen_base); + info->screen_base = NULL; + } return ret; } @@ -3695,6 +3699,10 @@ static int __devinit atyfb_atari_probe(v } if (aty_init(info, "ISA bus")) { + if (info->screen_base) + iounmap(info->screen_base); + if (par->ati_regbase) + iounmap(par->ati_regbase); framebuffer_release(info); /* This is insufficient! kernel_map has added two large chunks!! */ return -ENXIO; _