From: Adrian Bunk The correct order is: NULL check before dereference Spotted by the Coverity checker. Signed-off-by: Adrian Bunk Cc: Greg KH Signed-off-by: Andrew Morton --- drivers/pci/hotplug/ibmphp_pci.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN drivers/pci/hotplug/ibmphp_pci.c~drivers-pci-hotplug-ibmphp_pcic-fix-null-dereference drivers/pci/hotplug/ibmphp_pci.c --- a/drivers/pci/hotplug/ibmphp_pci.c~drivers-pci-hotplug-ibmphp_pcic-fix-null-dereference +++ a/drivers/pci/hotplug/ibmphp_pci.c @@ -1371,12 +1371,12 @@ static int unconfigure_boot_bridge (u8 b } bus = ibmphp_find_res_bus (sec_number); - debug ("bus->busno is %x\n", bus->busno); - debug ("sec_number is %x\n", sec_number); if (!bus) { err ("cannot find Bus structure for the bridged device\n"); return -EINVAL; } + debug("bus->busno is %x\n", bus->busno); + debug("sec_number is %x\n", sec_number); ibmphp_remove_bus (bus, busno); _