From: Akinobu Mita The return value of create_write_pipe()/create_read_pipe() should be checked by IS_ERR(). Signed-off-by: Akinobu Mita Signed-off-by: Andrew Morton --- kernel/kmod.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff -puN kernel/kmod.c~fix-create_write_pipe-error-check kernel/kmod.c --- a/kernel/kmod.c~fix-create_write_pipe-error-check +++ a/kernel/kmod.c @@ -307,14 +307,14 @@ int call_usermodehelper_pipe(char *path, return 0; f = create_write_pipe(); - if (!f) - return -ENOMEM; + if (IS_ERR(f)) + return PTR_ERR(f); *filp = f; f = create_read_pipe(f); - if (!f) { + if (IS_ERR(f)) { free_write_pipe(*filp); - return -ENOMEM; + return PTR_ERR(f); } sub_info.stdin = f; _