From: Hugh Dickins grp_goal 0 is a genuine goal (unlike -1), so ext2_try_to_allocate_with_rsv should treat it as such. Signed-off-by: Hugh Dickins Cc: Martin Bligh Acked-by: Mingming Cao Signed-off-by: Andrew Morton --- fs/ext2/balloc.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -puN fs/ext2/balloc.c~ext2-balloc-fix-off-by-one-against-grp_goal fs/ext2/balloc.c --- a/fs/ext2/balloc.c~ext2-balloc-fix-off-by-one-against-grp_goal +++ a/fs/ext2/balloc.c @@ -1053,7 +1053,7 @@ ext2_try_to_allocate_with_rsv(struct sup } /* * grp_goal is a group relative block number (if there is a goal) - * 0 < grp_goal < EXT2_BLOCKS_PER_GROUP(sb) + * 0 <= grp_goal < EXT2_BLOCKS_PER_GROUP(sb) * first block is a filesystem wide block number * first block is the block number of the first block in this group */ @@ -1089,7 +1089,7 @@ ext2_try_to_allocate_with_rsv(struct sup if (!goal_in_my_reservation(&my_rsv->rsv_window, grp_goal, group, sb)) grp_goal = -1; - } else if (grp_goal > 0) { + } else if (grp_goal >= 0) { int curr = my_rsv->rsv_end - (grp_goal + group_first_block) + 1; _