From cornelia.huck@de.ibm.com Mon Nov 27 01:34:46 2006 Date: Mon, 27 Nov 2006 10:35:12 +0100 From: Cornelia Huck To: Greg K-H Cc: Andrew Morton Subject: driver core: Change function call order in device_bind_driver(). Message-ID: <20061127103512.5d0aebb2@gondolin.boeblingen.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII From: Cornelia Huck Change function call order in device_bind_driver(). If we create symlinks (which might fail) before adding the device to the list we don't have to clean up afterwards (which we didn't). Signed-off-by: Cornelia Huck Signed-off-by: Greg Kroah-Hartman --- drivers/base/dd.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- gregkh-2.6.orig/drivers/base/dd.c +++ gregkh-2.6/drivers/base/dd.c @@ -86,8 +86,12 @@ static void driver_sysfs_remove(struct d */ int device_bind_driver(struct device *dev) { - driver_bound(dev); - return driver_sysfs_add(dev); + int ret; + + ret = driver_sysfs_add(dev); + if (!ret) + driver_bound(dev); + return ret; } struct stupid_thread_structure {