From: Akinobu Mita i2c-dev: Fix return value check device_create() returns error code as pointer on failures. This patch checks the return value of device_create() by using IS_ERR(). Signed-off-by: Akinobu Mita Cc: Greg Kroah-Hartman Signed-off-by: Jean Delvare --- drivers/i2c/i2c-dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.19-rc5.orig/drivers/i2c/i2c-dev.c 2006-11-13 10:52:30.000000000 +0100 +++ linux-2.6.19-rc5/drivers/i2c/i2c-dev.c 2006-11-13 10:52:38.000000000 +0100 @@ -416,8 +416,8 @@ i2c_dev->dev = device_create(i2c_dev_class, &adap->dev, MKDEV(I2C_MAJOR, adap->nr), "i2c-%d", adap->nr); - if (!i2c_dev->dev) { - res = -ENODEV; + if (IS_ERR(i2c_dev->dev)) { + res = PTR_ERR(i2c_dev->dev); goto error; } res = device_create_file(i2c_dev->dev, &dev_attr_name);