From: "Robert P. J. Day" Rewrite the Fusion MPT Kconfig file so that all of MPT functionality is entirely selectable from "Device drivers." The original Kconfig file seems to have an odd structure, as you can see from the first part of the file: ======================================================== menu "Fusion MPT device support" config FUSION bool default n config FUSION_SPI tristate "Fusion MPT ScsiHost drivers for SPI" depends on PCI && SCSI select FUSION select SCSI_SPI_ATTRS ... ======================================================== Note how the majority of entries in that file don't directly *depend* on FUSION. instead, they depend on *external* config variables, and *select* FUSION, and this is not the only place i've noticed that kind of dependency wording. Is that a regular feature? having that structure certainly makes it slightly more difficult to rewrite the menu entries, and it's not clear there's any obvious advantage to doing it that way. Signed-off-by: Robert P. J. Day Cc: "Moore, Eric Dean" Cc: James Bottomley Signed-off-by: Andrew Morton --- drivers/message/fusion/Kconfig | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff -puN drivers/message/fusion/Kconfig~kbuild-make-fusion-mpt-selectable-from-device-drivers drivers/message/fusion/Kconfig --- a/drivers/message/fusion/Kconfig~kbuild-make-fusion-mpt-selectable-from-device-drivers +++ a/drivers/message/fusion/Kconfig @@ -1,14 +1,12 @@ - -menu "Fusion MPT device support" - -config FUSION - bool +menuconfig FUSION + bool "Fusion MPT device support" default n +if FUSION + config FUSION_SPI tristate "Fusion MPT ScsiHost drivers for SPI" depends on PCI && SCSI - select FUSION select SCSI_SPI_ATTRS ---help--- SCSI HOST support for a parallel SCSI host adapters. @@ -23,7 +21,6 @@ config FUSION_SPI config FUSION_FC tristate "Fusion MPT ScsiHost drivers for FC" depends on PCI && SCSI - select FUSION select SCSI_FC_ATTRS ---help--- SCSI HOST support for a Fiber Channel host adapters. @@ -40,7 +37,6 @@ config FUSION_FC config FUSION_SAS tristate "Fusion MPT ScsiHost drivers for SAS" depends on PCI && SCSI - select FUSION select SCSI_SAS_ATTRS ---help--- SCSI HOST support for a SAS host adapters. @@ -100,4 +96,4 @@ config FUSION_LAN If unsure whether you really want or need this, say N. -endmenu +endif _