From: Andrew Morton Moer kernely. Cc: Robert Hancock Cc: Jeff Garzik Cc: Tejun Heo Signed-off-by: Andrew Morton --- drivers/ata/sata_nv.c | 29 ++++++++++++++++++----------- 1 file changed, 18 insertions(+), 11 deletions(-) diff -puN drivers/ata/sata_nv.c~sata_nv-add-back-some-verbosity-into-adma-error_handler-tidy drivers/ata/sata_nv.c --- a/drivers/ata/sata_nv.c~sata_nv-add-back-some-verbosity-into-adma-error_handler-tidy +++ a/drivers/ata/sata_nv.c @@ -1443,31 +1443,38 @@ static void nv_adma_error_handler(struct int i; u16 tmp; - if(ata_tag_valid(ap->active_tag) || ap->sactive) { + if (ata_tag_valid(ap->active_tag) || ap->sactive) { u32 notifier = readl(mmio + NV_ADMA_NOTIFIER); u32 notifier_error = readl(mmio + NV_ADMA_NOTIFIER_ERROR); u32 gen_ctl = readl(pp->gen_block + NV_ADMA_GEN_CTL); u32 status = readw(mmio + NV_ADMA_STAT); - ata_port_printk(ap, KERN_ERR, "EH in ADMA mode, notifier 0x%X " - "notifier_error 0x%X gen_ctl 0x%X status 0x%X\n", + ata_port_printk(ap, KERN_ERR, "EH in ADMA mode, " + "notifier 0x%X notifier_error 0x%X gen_ctl " + "0x%X status 0x%X\n", notifier, notifier_error, gen_ctl, status); - for( i=0;icpb[i]; - if( (ata_tag_valid(ap->active_tag) && i == ap->active_tag) || - ap->sactive & (1 << i) ) - ata_port_printk(ap, KERN_ERR, - "CPB %d: ctl_flags 0x%x, resp_flags 0x%x\n", - i, cpb->ctl_flags, cpb->resp_flags); + if ((ata_tag_valid(ap->active_tag) && + i == ap->active_tag) || + ap->sactive & (1 << i)) + ata_port_printk(ap, KERN_ERR, "CPB %d: " + "ctl_flags 0x%x, resp_flags " + "0x%x\n", + i, cpb->ctl_flags, + cpb->resp_flags); } } /* Push us back into port register mode for error handling. */ nv_adma_register_mode(ap); - /* Mark all of the CPBs as invalid to prevent them from being executed */ - for( i=0;icpb[i].ctl_flags &= ~NV_CPB_CTL_CPB_VALID; /* clear CPB fetch count */ _