From: Alexey Dobriyan /proc/$PID/fd has r-x------ permissions, so if process does setuid(), it will not be able to access /proc/*/fd/. This breaks fstatat() emulation in glibc. open("foo", O_RDONLY|O_DIRECTORY) = 4 setuid32(65534) = 0 stat64("/proc/self/fd/4/bar", 0xbfafb298) = -1 EACCES (Permission denied) Signed-off-by: Alexey Dobriyan Cc: "Eric W. Biederman" Cc: James Morris Cc: Chris Wright Cc: Ulrich Drepper Cc: Oleg Nesterov Acked-By: Kirill Korotaev Cc: Al Viro Cc: Christoph Hellwig Signed-off-by: Andrew Morton --- fs/proc/base.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff -puN fs/proc/base.c~allow-access-to-proc-pid-fd-after-setuid fs/proc/base.c --- a/fs/proc/base.c~allow-access-to-proc-pid-fd-after-setuid +++ a/fs/proc/base.c @@ -1447,11 +1447,28 @@ static const struct file_operations proc .readdir = proc_readfd, }; +static int proc_fd_permission(struct inode *inode, int mask, + struct nameidata *nd) +{ + struct task_struct *tsk; + int rv; + + rv = generic_permission(inode, mask, NULL); + if (rv == 0) + return 0; + tsk = get_proc_task(inode); + if (tsk == current) + rv = 0; + put_task_struct(tsk); + return rv; +} + /* * proc directories can do almost nothing.. */ static const struct inode_operations proc_fd_inode_operations = { .lookup = proc_lookupfd, + .permission = proc_fd_permission, .setattr = proc_setattr, }; _