From: Andrew Morton drivers/net/forcedeth.c: In function 'nv_tx_done': drivers/net/forcedeth.c:1906: warning: format '%ld' expects type 'long int', but argument 2 has type 'int' drivers/net/forcedeth.c:1906: warning: format '%ld' expects type 'long int', but argument 3 has type 'int' drivers/net/forcedeth.c:1926: warning: format '%ld' expects type 'long int', but argument 2 has type 'int' drivers/net/forcedeth.c:1926: warning: format '%ld' expects type 'long int', but argument 3 has type 'int' - Print ptrdiff_t's correctly - My xterms aren't as studly as yours. Cc: Ingo Molnar Cc: Ayaz Abdulla Cc: Jeff Garzik Signed-off-by: Andrew Morton --- drivers/net/forcedeth.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff -puN drivers/net/forcedeth.c~forcedeth-work-around-null-skb-dereference-crash-fix drivers/net/forcedeth.c --- a/drivers/net/forcedeth.c~forcedeth-work-around-null-skb-dereference-crash-fix +++ a/drivers/net/forcedeth.c @@ -1903,7 +1903,12 @@ static void nv_tx_done(struct net_device np->stats.tx_errors++; } else { if (!np->get_tx_ctx->skb) { - printk("get_tx: %ld, put_tx: %ld\n", np->get_tx_ctx - np->first_tx_ctx, np->put_tx_ctx - np->first_tx_ctx); + printk("get_tx: %td, put_tx: " + "%td\n", + np->get_tx_ctx - + np->first_tx_ctx, + np->put_tx_ctx - + np->first_tx_ctx); WARN_ON(1); break; } @@ -1923,7 +1928,12 @@ static void nv_tx_done(struct net_device np->stats.tx_errors++; } else { if (!np->get_tx_ctx->skb) { - printk("get_tx: %ld, put_tx: %ld\n", np->get_tx_ctx - np->first_tx_ctx, np->put_tx_ctx - np->first_tx_ctx); + printk("get_tx: %td, put_tx: " + "%td\n", + np->get_tx_ctx - + np->first_tx_ctx, + np->put_tx_ctx - + np->first_tx_ctx); WARN_ON(1); break; } _